[ 
https://issues.apache.org/jira/browse/NIFIREG-120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343095#comment-16343095
 ] 

ASF GitHub Bot commented on NIFIREG-120:
----------------------------------------

Github user abinet commented on the issue:

    https://github.com/apache/nifi-registry/pull/89
  
    Just some remark.
    This code in ./nifi-registry-docker/dockerhub/sh/start.sh
    
    ```
    # Establish baseline properties
    prop_replace 'nifi.registry.web.http.port'      '18080'
    prop_replace 'nifi.registry.web.http.host'     "${hostname}"
    ```
    
    will prevent properly running nifi-registry container in https mode. So 
maybe it is better to copy the complete approach from apache/nifi with running 
the secure.sh script
    
    
https://github.com/apache/nifi/blob/8bdc2910e1e0da4e49dd45123327b4b1d37ca640/nifi-docker/dockerhub/sh/start.sh#L30
    



> Basic Docker Image
> ------------------
>
>                 Key: NIFIREG-120
>                 URL: https://issues.apache.org/jira/browse/NIFIREG-120
>             Project: NiFi Registry
>          Issue Type: Improvement
>    Affects Versions: 0.1.0
>            Reporter: Daniel Chaffelson
>            Priority: Minor
>             Fix For: 0.2.0
>
>
> It would be convenient if NiFi Registry had an integrated Docker image ready 
> for uploading to Dockerhub, similar to the main NiFi Project, for ease of 
> integration testing.
> This could probably be ported, with some changes, from the same approach used 
> in the main NiFi project for continuity.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to