Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2443#discussion_r164607830
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/GetMongo.java
---
@@ -89,6 +99,17 @@ public ValidationResult validate(final String subject,
final String value, final
.expressionLanguageSupported(true)
.addValidator(DOCUMENT_VALIDATOR)
.build();
+
+ static final AllowableValue LOC_BODY = new AllowableValue("body",
"Body");
+ static final AllowableValue LOC_PARAM = new AllowableValue("param",
"Query Parameter");
+ static final PropertyDescriptor QUERY_LOC = new
PropertyDescriptor.Builder()
--- End diff --
We can ask the users list to get UX and other feedback, for ExecuteSQL it
was natural because the query used to be required, then we relaxed it and added
doc to the property saying if left blank, the contents of the flow file are
expected to have the SQL to execute. In this case, a blank setting is already
meaningful, so we may need two properties. "Explicit is better" is a good rule
of thumb, but now we have two properties that interact with each other in
different ways, which can also be confusing (see my other comments on when
things are set to various value combos)
---
