[ 
https://issues.apache.org/jira/browse/NIFIREG-120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16350688#comment-16350688
 ] 

ASF GitHub Bot commented on NIFIREG-120:
----------------------------------------

Github user kevdoran commented on a diff in the pull request:

    https://github.com/apache/nifi-registry/pull/89#discussion_r165667293
  
    --- Diff: nifi-registry-docker/dockerhub/sh/update_login_providers.sh ---
    @@ -0,0 +1,48 @@
    +#!/bin/sh -e
    +
    +#    Licensed to the Apache Software Foundation (ASF) under one or more
    +#    contributor license agreements.  See the NOTICE file distributed with
    +#    this work for additional information regarding copyright ownership.
    +#    The ASF licenses this file to You under the Apache License, Version 
2.0
    +#    (the "License"); you may not use this file except in compliance with
    +#    the License.  You may obtain a copy of the License at
    +#
    +#       http://www.apache.org/licenses/LICENSE-2.0
    +#
    +#    Unless required by applicable law or agreed to in writing, software
    +#    distributed under the License is distributed on an "AS IS" BASIS,
    +#    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or 
implied.
    +#    See the License for the specific language governing permissions and
    +#    limitations under the License.
    +
    +login_providers_file=${NIFI_REGISTRY_HOME}/conf/identity-providers.xml
    +property_xpath='//identityProviders/provider/property'
    +
    +# Update a given property in the login-identity-providers file if a value 
is specified
    +edit_property() {
    +  property_name=$1
    +  property_value=$2
    +
    +  if [ -n "${property_value}" ]; then
    +    xmlstarlet ed --inplace -u 
"${property_xpath}[@name='${property_name}']" -v "${property_value}" 
"${login_providers_file}"
    +  fi
    +}
    +
    +# Remove comments to enable the ldap-provider
    +sed -i '/To enable the ldap-identity-provider remove/d' 
"${login_providers_file}"
    +
    +edit_property 'Authentication Strategy'     
"${LDAP_AUTHENTICATION_STRATEGY}"
    +edit_property 'Manager DN'                  "${LDAP_MANAGER_DN}"
    +edit_property 'Manager Password'            "${LDAP_MANAGER_PASSWORD}"
    +edit_property 'TLS - Keystore'              "${LDAP_TLS_KEYSTORE}"
    +edit_property 'TLS - Keystore Password'     "${LDAP_TLS_KEYSTORE_PASSWORD}"
    +edit_property 'TLS - Keystore Type'         "${LDAP_TLS_KEYSTORE_TYPE}"
    +edit_property 'TLS - Truststore'            "${LDAP_TLS_TRUSTSTORE}"
    +edit_property 'TLS - Truststore Password'   
"${LDAP_TLS_TRUSTSTORE_PASSWORD}"
    +edit_property 'TLS - Truststore Type'       "${LDAP_TLS_TRUSTSTORE_TYPE}"
    +edit_property 'TLS - Protocol'              "${LDAP_TLS_PROTOCOL}"
    +edit_property 'Url'                         "${LDAP_URL}"
    +edit_property 'User Search Base'            "${LDAP_USER_SEARCH_BASE}"
    +edit_property 'User Search Filter'          "${LDAP_USER_SEARCH_FILTER}"
    +<<<<<<< f271b0a5e09d90ac935c655f3a9d2faa0957a646
    --- End diff --
    
    Conflict resolution artifact; remove line 47.


> Basic Docker Image
> ------------------
>
>                 Key: NIFIREG-120
>                 URL: https://issues.apache.org/jira/browse/NIFIREG-120
>             Project: NiFi Registry
>          Issue Type: Improvement
>    Affects Versions: 0.1.0
>            Reporter: Daniel Chaffelson
>            Priority: Minor
>             Fix For: 0.2.0
>
>
> It would be convenient if NiFi Registry had an integrated Docker image ready 
> for uploading to Dockerhub, similar to the main NiFi Project, for ease of 
> integration testing.
> This could probably be ported, with some changes, from the same approach used 
> in the main NiFi project for continuity.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to