Github user mattyb149 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2180#discussion_r165994717
  
    --- Diff: 
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/AbstractMongoProcessor.java
 ---
    @@ -95,13 +101,50 @@
     
         public static final PropertyDescriptor WRITE_CONCERN = new 
PropertyDescriptor.Builder()
                 .name("Write Concern")
    +            .displayName("Write Concern")
                 .description("The write concern to use")
                 .required(true)
                 .allowableValues(WRITE_CONCERN_ACKNOWLEDGED, 
WRITE_CONCERN_UNACKNOWLEDGED, WRITE_CONCERN_FSYNCED, WRITE_CONCERN_JOURNALED,
                         WRITE_CONCERN_REPLICA_ACKNOWLEDGED, 
WRITE_CONCERN_MAJORITY)
                 .defaultValue(WRITE_CONCERN_ACKNOWLEDGED)
                 .build();
     
    +    static final PropertyDescriptor RESULTS_PER_FLOWFILE = new 
PropertyDescriptor.Builder()
    +            .name("results-per-flowfile")
    +            .displayName("Results Per FlowFile")
    +            .description("How many results to put into a flowfile at once. 
The whole body will be treated as a JSON array of results.")
    +            .required(false)
    +            .addValidator(StandardValidators.POSITIVE_INTEGER_VALIDATOR)
    +            .defaultValue("1")
    +            .build();
    +
    +    static final PropertyDescriptor BATCH_SIZE = new 
PropertyDescriptor.Builder()
    +            .name("Batch Size")
    +            .displayName("Batch Size")
    +            .description("The number of elements returned from the server 
in one batch.")
    +            .required(false)
    +            .addValidator(StandardValidators.POSITIVE_INTEGER_VALIDATOR)
    +            .defaultValue("100")
    +            .build();
    +
    +    static final PropertyDescriptor QUERY_ATTRIBUTE = new 
PropertyDescriptor.Builder()
    +            .name("mongo-agg-query-attribute")
    --- End diff --
    
    Since this is common to Mongo processors, the name should probably reflect 
that.


---

Reply via email to