Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/259#discussion_r166148325
  
    --- Diff: extensions/mqtt/ConsumeMQTT.cpp ---
    @@ -35,7 +35,7 @@ namespace nifi {
     namespace minifi {
     namespace processors {
     
    -core::Property ConsumeMQTT::MaxQueueSize("Max Flow Segment Size", "Maximum 
flow content payload segment size for the MQTT record", "");
    +core::Property ConsumeMQTT::MaxQueueSize("Max Queue Size", "Maximum 
receive queue size for the MQTT record", "");
    --- End diff --
    
    I see your point that the variable name doesn't equal the option name "Max 
Flow Segment Size" vs "Max Queue Size" , but if a user happens to be using "Max 
flow segment size" per the option we've changed the semantics of what they 
want. Does that make sense? We should have that option available to them until 
we can deprecate it. Further, "receive queue size" seems to not connote if the 
size is in the number of flow files or the number of bytes. That should be 
clarified. 


---

Reply via email to