[ 
https://issues.apache.org/jira/browse/NIFI-4521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16353220#comment-16353220
 ] 

ASF GitHub Bot commented on NIFI-4521:
--------------------------------------

Github user patricker commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2231#discussion_r166168965
  
    --- Diff: 
nifi-nar-bundles/nifi-cdc/nifi-cdc-mssql-bundle/nifi-cdc-mssql-processors/src/main/java/org/apache/nifi/cdc/mssql/MSSQLCDCUtils.java
 ---
    @@ -0,0 +1,264 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.nifi.cdc.mssql;
    +
    +import org.apache.nifi.cdc.CDCException;
    +import org.apache.nifi.cdc.event.ColumnDefinition;
    +import org.apache.nifi.cdc.mssql.event.MSSQLColumnDefinition;
    +import org.apache.nifi.cdc.mssql.event.MSSQLTableInfo;
    +
    +import java.sql.Connection;
    +import java.sql.Timestamp;
    +import java.sql.Types;
    +import java.sql.PreparedStatement;
    +import java.sql.ResultSet;
    +import java.sql.SQLException;
    +import java.sql.Statement;
    +import java.util.ArrayList;
    +import java.util.List;
    +
    +public class MSSQLCDCUtils {
    --- End diff --
    
    Yes and no. The main code would be fine with just static's, but the unit 
test needs to override certain methods. (ref `MockCaptureChangeMSSQL` in 
`CaptureChangeMSSQLTest`)


> MS SQL CDC Processor
> --------------------
>
>                 Key: NIFI-4521
>                 URL: https://issues.apache.org/jira/browse/NIFI-4521
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions
>            Reporter: Peter Wicks
>            Assignee: Peter Wicks
>            Priority: Major
>
> Creation of a new processor that reads Change Data Capture details from 
> Microsoft SQL Server and outputs the changes a Records.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to