[ 
https://issues.apache.org/jira/browse/NIFI-4774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16373414#comment-16373414
 ] 

ASF GitHub Bot commented on NIFI-4774:
--------------------------------------

Github user mattyb149 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2487#discussion_r170084710
  
    --- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/repository/WriteAheadFlowFileRepository.java
 ---
    @@ -129,17 +138,22 @@ public WriteAheadFlowFileRepository() {
             checkpointDelayMillis = 0l;
             numPartitions = 0;
             checkpointExecutor = null;
    -        flowFileRepositoryPath = null;
    +        walImplementation = null;
    --- End diff --
    
    Should this be DEFAULT_WAL_IMPLEMENTATION?


> FlowFile Repository should write updates to the same FlowFile to the same 
> partition
> -----------------------------------------------------------------------------------
>
>                 Key: NIFI-4774
>                 URL: https://issues.apache.org/jira/browse/NIFI-4774
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework
>            Reporter: Mark Payne
>            Assignee: Mark Payne
>            Priority: Major
>             Fix For: 1.6.0
>
>
> As-is, in the case of power loss or Operating System crash, we could have an 
> update that is lost, and then an update for the same FlowFile that is not 
> lost, because the updates for a given FlowFile can span partitions. If an 
> update were written to Partition 1 and then to Partition 2 and Partition 2 is 
> flushed to disk by the Operating System and then the Operating System crashes 
> or power is lost before Partition 1 is flushed to disk, we could lose the 
> update to Partition 1.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to