Github user MikeThomsen commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2553#discussion_r174878824
  
    --- Diff: 
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service/src/test/java/org/apache/nifi/pulsar/TestStandardPulsarClientService.java
 ---
    @@ -0,0 +1,44 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.nifi.pulsar;
    +
    +import org.apache.nifi.reporting.InitializationException;
    +import org.apache.nifi.util.TestRunner;
    +import org.apache.nifi.util.TestRunners;
    +import org.junit.Before;
    +import org.junit.Test;
    +
    +public class TestStandardPulsarClientService {
    +
    +    @Before
    +    public void init() {
    +
    +    }
    +
    +    @Test
    +    public void testService() throws InitializationException {
    +        final TestRunner runner = 
TestRunners.newTestRunner(TestProcessor.class);
    +        final PulsarClientPool service = new StandardPulsarClientPool();
    +        runner.addControllerService("test-good", service);
    +
    +        runner.setProperty(service, 
StandardPulsarClientPool.PULSAR_SERVICE_URL, "localhost:6667");
    +        // runner.enableControllerService(service);
    --- End diff --
    
    I think you might actually needs this. If that's not the case, it should be 
removed.


---

Reply via email to