[
https://issues.apache.org/jira/browse/NIFI-4864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16412431#comment-16412431
]
ASF GitHub Bot commented on NIFI-4864:
--------------------------------------
GitHub user zenfenan opened a pull request:
https://github.com/apache/nifi/pull/2581
NIFI-4864: Improvements to PR #2470
The original PR #2470 had an unhandled situation wherein the components
that don't have any `PropertyDescriptor` marked as
`dynamicallyModifiesClasspath(true)` won't have the
`additionalResourcesFingerprint` set i.e. it will be null so the framework will
attempt to reload the resources. This caused an unexpected scenario especially
when using Schema Registry services which @bbende explained in the [Release
Apache NiFi 1.6.0 Dev
thread](http://apache-nifi-developer-list.39713.n7.nabble.com/VOTE-Release-Apache-NiFi-1-6-0-td18236.html#a18259)
I have tested both the scenarios:
1. The actual reason why this ticket was raised i.e. to smartly reload
*newly added* additional resources, upon the component's start and stop
1. The unhandled situation that is mentioned above (schema registry
situation)
---
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zenfenan/nifi NIFI-4864-RO
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2581.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2581
----
commit 5c08f0d793cd5e492a1b79e2535f9329aa6c40fe
Author: zenfenan <sivaprasanna246@...>
Date: 2018-03-24T05:19:48Z
NIFI-4864: Improvements to PR #2470
----
> Additional Resources property pointing at a directory won't find new JARs
> -------------------------------------------------------------------------
>
> Key: NIFI-4864
> URL: https://issues.apache.org/jira/browse/NIFI-4864
> Project: Apache NiFi
> Issue Type: Bug
> Affects Versions: 1.2.0, 1.3.0, 1.4.0, 1.5.0
> Reporter: Bryan Bende
> Assignee: Sivaprasanna Sethuraman
> Priority: Blocker
> Fix For: 1.6.0
>
>
> If you have a processor/Controller Service/Reporting Task that has a property
> with dynamicallyModifiesClasspath(true) and you set the value to a directory,
> the resources in that directory will only be calculated when that property
> changes. This means if you added JARs to the directory later, and stopped and
> started your processor, those new JARs still won't be available. You would
> have to change the property to a new directory, or back and forth to some
> other directory, to force a recalculation.
> The setProperties method in AbstractConfiguredComponent is where it looks at
> incoming property changes and determines if any were for classpath related
> properties and then calls reload accordingly.
> We would need to consider the case where setProperties is never even being
> called, someone just stops and starts the processor and would want to pick up
> any new JARs added.
> A possible solution might be to computer some kind of hash/fingerprint of the
> URLs each time reload is called, and then when starting the processor we
> could recompute the fingerprint and compare it to the previous one. If they
> are different then we call reload before starting the component.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
