[
https://issues.apache.org/jira/browse/NIFI-5013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16412625#comment-16412625
]
ASF GitHub Bot commented on NIFI-5013:
--------------------------------------
Github user apiri commented on the issue:
https://github.com/apache/nifi/pull/2580
sorry, forgot to check back after I kicked off my local build last night.
code, contrib, and tests all look good. less is more! Thanks for taking care
of this. Merging.
> NiFi Standard Processors should build a test jar to reduce duplication
> ----------------------------------------------------------------------
>
> Key: NIFI-5013
> URL: https://issues.apache.org/jira/browse/NIFI-5013
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Otto Fowler
> Assignee: Otto Fowler
> Priority: Major
>
> There are some classes, notably TestServer, which are in the nifi standard
> processors jar which could be used by other processors, either in the project
> ( already 2 or 3 copies ) or in 3rd party processor/controller projects.
> [link Apache
> Maven|https://maven.apache.org/plugins/maven-jar-plugin/examples/create-test-jar.html]
> details how to handle this case in two ways.
>
> # create a test-jar from the project
> # create a new module to hold shared testing code and scope:test include it
> While #2 is the preferred way, nifi should support #1 in the interim, until
> some discussion on the location and structure of the test module(s) and the
> classes that should be moved to them happens. The scope there will be quite
> a bit larger.
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
