[
https://issues.apache.org/jira/browse/NIFI-4977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16414046#comment-16414046
]
ASF GitHub Bot commented on NIFI-4977:
--------------------------------------
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2547#discussion_r177146046
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AbstractSyslogProcessor.java
---
@@ -29,34 +29,28 @@
public static final AllowableValue TCP_VALUE = new
AllowableValue("TCP", "TCP");
public static final AllowableValue UDP_VALUE = new
AllowableValue("UDP", "UDP");
- public static final PropertyDescriptor PROTOCOL = new
PropertyDescriptor
+ public static final PropertyDescriptor PROTOCOL_PROP = new
PropertyDescriptor
.Builder().name("Protocol")
.description("The protocol for Syslog communication.")
.required(true)
.allowableValues(TCP_VALUE, UDP_VALUE)
.defaultValue(UDP_VALUE.getValue())
.build();
- public static final PropertyDescriptor PORT = new PropertyDescriptor
+ public static final PropertyDescriptor.Builder PORT_PROP_BUILDER = new
PropertyDescriptor
--- End diff --
Yeah, the reason was just that I was shying away from modifying the
ListenSyslog processor as well but that's probably a better way to go. Will fix
> PutSyslog should support Expression Language for it's Sender properties
> -----------------------------------------------------------------------
>
> Key: NIFI-4977
> URL: https://issues.apache.org/jira/browse/NIFI-4977
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Joseph Percivall
> Assignee: Joseph Percivall
> Priority: Minor
>
> As part of the continued effort to add access to the variable registry to
> processors, the PutSyslog processor should expose expression language to it's
> sender properties. These properties control where and how the processor sends
> to.
> This update should better align PutSyslog with the other PutX processors
> which support EL on the sender properties (Slack, TCP, UDP).
> These properties are not evaluated per FlowFile and shouldn't be expected to
> change between onTriggers (since the sender pool is shared) so it will need
> to be documented as such that the
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
