Github user sbouchex commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2585#discussion_r177528070
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListenHTTP.java
 ---
    @@ -213,6 +260,8 @@ private void createHttpServerFromService(final 
ProcessContext context) throws Ex
             final Double maxBytesPerSecond = 
context.getProperty(MAX_DATA_RATE).asDataSize(DataUnit.B);
             final StreamThrottler streamThrottler = (maxBytesPerSecond == 
null) ? null : new LeakyBucketStreamThrottler(maxBytesPerSecond.intValue());
             final int returnCode = 
context.getProperty(RETURN_CODE).asInteger();
    +        final String authenticationUsername = 
trimToEmpty(context.getProperty(PROP_BASIC_AUTH_USERNAME).evaluateAttributeExpressions().getValue());
    +        final String authenticationPassword = 
trimToEmpty(context.getProperty(PROP_BASIC_AUTH_PASSWORD).evaluateAttributeExpressions().getValue());
    --- End diff --
    
    I'll force use of HTTPS for basic auth. That's probably safer.


---

Reply via email to