[ 
https://issues.apache.org/jira/browse/NIFI-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16416253#comment-16416253
 ] 

ASF GitHub Bot commented on NIFI-4658:
--------------------------------------

Github user mosermw commented on the issue:

    https://github.com/apache/nifi/pull/2559
  
    Hi @markobean, I reviewed this and I have a couple of questions.  I'm not 
sure I understand why the `throw e;` statements were removed from MergeContent. 
 Can you explain or put them back in?  Also, in TestMergeContent, I'm not sure 
why the `testDefragmentOldStyleAttributes()` test was removed.  The test still 
passes with the rest of your PR applied.  Was this perhaps part of the changes 
made before you modified the PR and force pushed?  Thanks for looking into this.


> MergeContent Max Number of Entries resetting to default value
> -------------------------------------------------------------
>
>                 Key: NIFI-4658
>                 URL: https://issues.apache.org/jira/browse/NIFI-4658
>             Project: Apache NiFi
>          Issue Type: Bug
>    Affects Versions: 1.4.0
>            Reporter: Brian Ghigiarelli
>            Assignee: Mark Bean
>            Priority: Major
>
> Prior to and including 1.4.0, the MergeContent processor supports a property 
> called "Maximum Number of Entries". It has a default value of 1,000. Prior to 
> 1.4.0 and in the description of this property, if the property is not set, 
> there will be no maximum number of files to include in a bundle.
> However, with the release of 1.4.0, if you clear the value of this property 
> in order to have an unlimited number of files in the bundle and "Apply" the 
> change, the next time that you open the configuration of the processor, it 
> will again be set to the default value of 1,000. The expectation is that the 
> cleared value will remain cleared, maintaining a configuration for an 
> unlimited number of files in a merge bundle.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to