[ https://issues.apache.org/jira/browse/NIFI-5017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16417389#comment-16417389 ]
ASF GitHub Bot commented on NIFI-5017: -------------------------------------- GitHub user ak-arun opened a pull request: https://github.com/apache/nifi/pull/2590 NIFI-5017 Code changes to accommodate Expression Languages Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ak-arun/nifi-1 NIFI-5017 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2590.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2590 ---- commit 954a0b0304c3a5ec11f77a1249c9501dfc73e16e Author: Arun A K <arun.cetly@...> Date: 2018-03-28T14:02:53Z Code changes to accommodate Expression Languages in support of NIFI-5017 commit 61d26ced76aa23f7f45ab2d957c6aeacb4555d5b Author: Arun A K <arun.cetly@...> Date: 2018-03-28T14:09:09Z Code changes to accommodate Expression Languages in support of NIFI-5017, checkstyle ---- > ConvertExcelToCSVProcessor should Support Expression Language for Number of > Rows to Skip and Columns To Skip > ------------------------------------------------------------------------------------------------------------- > > Key: NIFI-5017 > URL: https://issues.apache.org/jira/browse/NIFI-5017 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions > Affects Versions: 1.5.0 > Reporter: Arun A K > Priority: Minor > > The ConvertExcelToCSVProcessor should support expression language for fields > "Number of Rows to Skip" and "Columns To Skip". These two could be a > precomputed attribute or looked up value and need to be configurable via EL. -- This message was sent by Atlassian JIRA (v7.6.3#76005)