Github user MikeThomsen commented on the issue:

    https://github.com/apache/nifi/pull/2562
  
    @mans2singh I went to merge your changes this morning and found that you 
have some integration tests that are broken now with the changes made to EL 
support in the `PropertyDescriptor.Builder` class. It seems your breakage is 
limited mainly here:
    
    ```
    protected String makeProvenanceUrl(final ProcessContext context, String 
database, FlowFile flowFile) {
        return new StringBuilder("influxdb://")
            
.append(context.getProperty(INFLUX_DB_URL).evaluateAttributeExpressions(flowFile).getValue()).append("/")
            .append(database).toString();
    }
    ```
    
    You marked that property as `VARIABLE_REGISTRY` and it is failing because 
you're applying it flowfiles. The existing calls to 
`expressionLanguageSupported(boolean)` in the abstract class also need to be 
fixed.
    
    So just do a rebase against the latest master and take care of those. If 
there are no regressions after your commit (ie your flows and tests run) IMO 
we're ready to merge.


---

Reply via email to