[
https://issues.apache.org/jira/browse/NIFI-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435909#comment-16435909
]
ASF GitHub Bot commented on NIFI-543:
-------------------------------------
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2509#discussion_r181149446
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-processor-configuration.js
---
@@ -741,8 +742,8 @@
}
});
- // show the execution node option if we're cluster or
we're currently configured to run on the primary node only
- if (nfClusterSummary.isClustered() || executionNode
=== 'PRIMARY') {
+ // show the execution node option if we're clustered
and execution node is not restricted to run only in primary node
+ if (nfClusterSummary.isClustered() &&
executionNodeRestricted !== true) {
--- End diff --
How does this work in the case where the Processor previously did not have
`executionNodeRestricted` and the `executionNode` was `ALL`?
I'm wondering if we shouldn't be hiding this field in these scenarios.
Currently, if you're not clustered and the value is `PRIMARY` we show the field
but we disable the Primary options. Please refer to `getExecutionNodeOptions`
in nf-processor-configuration.js. I think the scenario I described above is
equivalent. If the existing value of `executionNode` was `ALL` we would want to
render that but disable that option as a choice.
> Provide extensions a way to indicate that they can run only on primary node,
> if clustered
> -----------------------------------------------------------------------------------------
>
> Key: NIFI-543
> URL: https://issues.apache.org/jira/browse/NIFI-543
> Project: Apache NiFi
> Issue Type: Sub-task
> Components: Core Framework, Documentation & Website, Extensions
> Reporter: Mark Payne
> Assignee: Sivaprasanna Sethuraman
> Priority: Major
>
> There are Processors that are known to be problematic if run from multiple
> nodes simultaneously. These processors should be able to use a
> @PrimaryNodeOnly annotation (or something similar) to indicate that they can
> be scheduled to run only on primary node if run in a cluster.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
