Github user peter-toth commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2630#discussion_r181746461
  
    --- Diff: pom.xml ---
    @@ -94,6 +94,7 @@
             <org.slf4j.version>1.7.25</org.slf4j.version>
             <ranger.version>0.7.1</ranger.version>
             <jetty.version>9.4.3.v20170317</jetty.version>
    +        <httpclient.version>4.5.5</httpclient.version>
    --- End diff --
    
    @mattyb149, could you please review my change and let me know if I did the 
right thing? Any suggestions are welcome.
    
    I changed the httpclient dependency to provided so it won't get into all 
NARs depending on nifi-hadoop-utils. Unfortunately httpclient seems to change a 
lot from version to version and the minimum required version that my changes 
can work with is 4.4.1.
    
    All my additions to hadoop-utils are in new classes, so I believe even a 
hadoop-utils dependent NAR that specifies a lower version of httpclient will be 
fine as long as it doesn't start to use my classes directly.


---

Reply via email to