[
https://issues.apache.org/jira/browse/MINIFICPP-464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16450372#comment-16450372
]
ASF GitHub Bot commented on MINIFICPP-464:
------------------------------------------
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/309
MINIFICPP-464 Clarify GetUSBCamera docs regarding scheduling behavior…
… and image quality selection
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] If applicable, have you updated the LICENSE file?
- [x] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-464
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/309.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #309
----
commit 6fd30cad0145cb6d38b33f2aa96b07e77e5b0824
Author: Andrew I. Christianson <andy@...>
Date: 2018-04-24T18:43:59Z
MINIFICPP-464 Clarify GetUSBCamera docs regarding scheduling behavior and
image quality selection
----
> Clarify GetUSBCamera docs on scheduling behavior
> ------------------------------------------------
>
> Key: MINIFICPP-464
> URL: https://issues.apache.org/jira/browse/MINIFICPP-464
> Project: NiFi MiNiFi C++
> Issue Type: Documentation
> Reporter: Andrew Christianson
> Assignee: Andrew Christianson
> Priority: Major
>
> The docs are currently unclear as to how GetUSBCamera gets frames from a
> camera. Since onTrigger is a NOOP, the usual scheduling mechanisms have no
> effect.
> Additionally, clarify how image formats are automatically chosen (and
> consider adding a new ticket/change to allow users to specify format), which
> is currently undocumented.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
