[ 
https://issues.apache.org/jira/browse/MINIFICPP-469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452656#comment-16452656
 ] 

ASF GitHub Bot commented on MINIFICPP-469:
------------------------------------------

Github user achristianson commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/307#discussion_r184138022
  
    --- Diff: extensions/expression-language/base64.h ---
    @@ -0,0 +1,188 @@
    
+/***************************************************************************
    --- End diff --
    
    This is the cURL base64 encode/decode. Here's why:
    
    1) Avoid reinventing the wheel
    2) It's a private function in cURL, so that's why it's copied rather than 
exposing/calling into cURL lib
    3) We already have cURL included & in LICENSE, so it's simple to use this 
one
    4) Simpler implementation to call than OpenSSL implementation


> Implement base64 encode/decode EL functions
> -------------------------------------------
>
>                 Key: MINIFICPP-469
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-469
>             Project: NiFi MiNiFi C++
>          Issue Type: Improvement
>            Reporter: Andrew Christianson
>            Assignee: Andrew Christianson
>            Priority: Major
>
> * 
> [base64Encode|https://nifi.apache.org/docs/nifi-docs/html/expression-language-guide.html#base64encode]
>  * 
> [base64Decode|https://nifi.apache.org/docs/nifi-docs/html/expression-language-guide.html#base64decode]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to