[GitHub] nifi pull request #2682: NIFI-4731: BQ Processors and GCP library update.

[danieljimenez]

Github user danieljimenez commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2682#discussion_r186428592
  
    --- Diff: 
nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/AbstractGCPProcessor.java
 ---
    @@ -36,14 +36,14 @@
      */
     public abstract class AbstractGCPProcessor<
             CloudService extends Service<CloudServiceOptions>,
    -        CloudServiceRpc,
    -        CloudServiceOptions extends HttpServiceOptions<CloudService, 
CloudServiceRpc, CloudServiceOptions>> extends AbstractProcessor {
    +        CloudServiceOptions extends ServiceOptions<CloudService, 
CloudServiceOptions>> extends AbstractProcessor {
     
         public static final PropertyDescriptor PROJECT_ID = new 
PropertyDescriptor
                 .Builder().name("gcp-project-id")
                 .displayName("Project ID")
                 .description("Google Cloud Project ID")
                 .required(true)
    +            
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
    --- End diff --
    
    I added variable registry support to the GCP project ID.


---