[GitHub] nifi pull request #2679: NIFI-5141: Updated regex for doubles to allow for n...

[bdesert]

Github user bdesert commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2679#discussion_r186609421
  
    --- Diff: 
nifi-commons/nifi-record/src/main/java/org/apache/nifi/serialization/record/util/DataTypeUtils.java
 ---
    @@ -60,19 +60,19 @@
         private static final String Infinity = "(Infinity)";
         private static final String NotANumber = "(NaN)";
     
    -    private static final String Base10Digits  = "\\d+";
    -    private static final String Base10Decimal  = "\\." + Base10Digits;
    -    private static final String OptionalBase10Decimal  = Base10Decimal + 
"?";
    +    private static final String Base10Digits = "\\d+";
    +    private static final String Base10Decimal = "\\." + Base10Digits;
    +    private static final String OptionalBase10Decimal = "(" + 
Base10Decimal + ")?";
     
    -    private static final String Base10Exponent      = "[eE]" + 
OptionalSign + Base10Digits;
    +    private static final String Base10Exponent = "[eE]" + OptionalSign + 
Base10Digits;
         private static final String OptionalBase10Exponent = "(" + 
Base10Exponent + ")?";
     
         private static final String  doubleRegex =
             OptionalSign +
             "(" +
                 Infinity + "|" +
                 NotANumber + "|"+
    -            "(" + Base10Digits + Base10Decimal + ")" + "|" +
    +            "(" + Base10Digits + OptionalBase10Decimal + ")" + "|" +
                 "(" + Base10Digits + OptionalBase10Decimal + Base10Exponent + 
")" + "|" +
    --- End diff --
    
    I think it'd be nice to have also:
    "(" + Base10Digits + "\\." + ")" + "|" + 



---