Github user anoopsjohn commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2518#discussion_r187593742
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-services/nifi-hbase_1_1_2-client-service-bundle/nifi-hbase_1_1_2-client-service/src/main/java/org/apache/nifi/hbase/HBase_1_1_2_ClientService.java
 ---
    @@ -336,51 +346,85 @@ public void shutdown() {
             }
         }
     
    +    private static final byte[] EMPTY_VIS_STRING;
    +
    +    static {
    +        try {
    +            EMPTY_VIS_STRING = "".getBytes("UTF-8");
    +        } catch (UnsupportedEncodingException e) {
    +            throw new RuntimeException(e);
    +        }
    +    }
    +
    +    private List<Put> buildPuts(byte[] rowKey, List<PutColumn> columns) {
    +        List<Put> retVal = new ArrayList<>();
    +
    +        try {
    +            Put put = null;
    +
    +            for (final PutColumn column : columns) {
    --- End diff --
    
    Allowing the different columns in same row to have diff visibility right.  
For each of the unique visibility one Put need to be there along with 
corresponding columns in it.  I believe the below logic is doing that. Just 
saying.


---

Reply via email to