[ 
https://issues.apache.org/jira/browse/NIFI-4907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16474537#comment-16474537
 ] 

Matt Gilman commented on NIFI-4907:
-----------------------------------

An endpoint could be categorized as data plane (downloading or manipulating 
attributes/content, etc) or control plane (configuring a component, etc - 
basically anything not data plane). For data plane endpoints, NiFi requires the 
entire chain to be authorized. This allows the authorizer to verify that an end 
user can have the data and that any proxy in the chain is also authorized to 
have the data (since the data is ultimately routing through those servers). In 
a NiFi cluster, any node can act as the Cluster Coorindator which replicates 
(routes) the requests to any/all nodes.

The existing 'view the data' policies would be considered data plane. I do not 
believe that the provenance event details would be considered data and would 
only require the end user has the necessary permission.

The authorization in this case would be:

1) Ensure the user is allowed to 'query provenance'

For each event

2) Ensure the user is allowed to 'view provenance' for the component

For each authorized event

3) Include component name/type if the user is allowed to 'view component'

4) Include attributes and content details if the user is allowed to 'view the 
data' for the component

Step (1) should already be in place. As part of this PR, you should be 
adding/updating (2), (3), and (4). In order to do (2), you'll need to add 
support for viewing/configuring the 'view provenance' policy for each 
component. Hope this helps.

> Provenance authorization refactoring
> ------------------------------------
>
>                 Key: NIFI-4907
>                 URL: https://issues.apache.org/jira/browse/NIFI-4907
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework
>    Affects Versions: 1.5.0
>            Reporter: Mark Bean
>            Assignee: Mark Bean
>            Priority: Major
>
> Currently, the 'view the data' component policy is too tightly coupled with 
> Provenance queries. The 'query provenance' policy should be the only policy 
> required for viewing Provenance query results. Both 'view the component' and 
> 'view the data' policies should be used to refine the appropriate visibility 
> of event details - but not the event itself.
> 1) Component Visibility
> The authorization of Provenance events is inconsistent with the behavior of 
> the graph. For example, if a user does not have 'view the component' policy, 
> the graph shows this component as a "black box" (no details such as name, 
> UUID, etc.) However, when querying Provenance, this component will show up 
> including the Component Type and the Component Name. This is in effect a 
> violation of the policy. These component details should be obscured in the 
> Provenance event displayed if user does not have the appropriate 'view the 
> component' policy.
> 2) Data Visibility
> For a Provenance query, all events should be visible as long as the user 
> performing the query belongs to the 'query provenance' global policy. As 
> mentioned above, some information about the component may be obscured 
> depending on 'view the component' policy, but the event itself should be 
> visible. Additionally, details of the event (clicking the View Details "i" 
> icon) should only be accessible if the user belongs to the 'view the data' 
> policy for the affected component. If the user is not in the appropriate 
> 'view the data' policy, a popup warning should be displayed indicating the 
> reason details are not visible with more specific detail than the current 
> "Contact the system administrator".
> 3) Lineage Graphs
> As with the Provenance table view recommendation above, the lineage graph 
> should display all events. Currently, if the lineage graph includes an event 
> belonging to a component which the user does not have 'view the data', it is 
> shown on the graph as "UNKNOWN". As with Data Visibility mentioned above, the 
> graph should indicate the event type as long as the user is in the 'view the 
> component'. Subsequent "View Details" on the event should only be visible if 
> the user is in the 'view the data' policy.
> In summary, for Provenance query results and lineage graphs, all events 
> should be shown. Component Name and Component Type information should be 
> conditionally visible depending on the corresponding component policy 'view 
> the component' policy. Event details including Provenance event type and 
> FlowFile information should be conditionally available depending on the 
> corresponding component policy 'view the data'. Inability to display event 
> details should provide feedback to the user indicating the reason.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to