[ https://issues.apache.org/jira/browse/NIFI-5213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16480125#comment-16480125 ]
ASF GitHub Bot commented on NIFI-5213: -------------------------------------- GitHub user mattyb149 opened a pull request: https://github.com/apache/nifi/pull/2718 NIFI-5213: Allow AvroReader to process files w embedded schema even when the access strategy is explicit schema Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [x] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mattyb149/nifi NIFI-5213 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2718.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2718 ---- commit 40b9e110abadf802780e2d697aeab336b50094b9 Author: Matthew Burgess <mattyb149@...> Date: 2018-05-18T04:29:52Z NIFI-5213: Allow AvroReader to process files w embedded schema even when the access strategy is explicit schema ---- > Allow AvroReader with explicit schema to read files with embedded schema > ------------------------------------------------------------------------ > > Key: NIFI-5213 > URL: https://issues.apache.org/jira/browse/NIFI-5213 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions > Reporter: Matt Burgess > Assignee: Matt Burgess > Priority: Minor > > AvroReader allows the choice of schema access strategy from such options as > Use Embedded Schema, Use Schema Name, Use Schema Text, etc. If the incoming > Avro files will have embedded schemas, then Use Embedded Schema is best > practice for the Avro Reader. However it is not intuitive that if the same > schema that is embedded in the file is specified by name (using a schema > registry) or explicitly via Schema Text, that errors can occur. This has been > noticed in QueryRecord for example, and the error is also not intuitive or > descriptive (it is often an ArrayIndexOutOfBoundsException). > To provide a better user experience, it would be an improvement for > AvroReader to be able to successfully process Avro files with embedded > schemas, even when the Schema Access Strategy is not "Use Embedded Schema". > Of course, the explicit schema would have to match the embedded schema, or an > error would be reported (and rightfully so). -- This message was sent by Atlassian JIRA (v7.6.3#76005)