Github user markap14 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2722#discussion_r189656654
  
    --- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/manager/StatusMerger.java
 ---
    @@ -415,13 +415,15 @@ public static void merge(final 
ProcessorStatusSnapshotDTO target, final boolean
                 target.setType(toMerge.getType());
             }
     
    -        // if the status to merge is invalid allow it to take precedence. 
whether the
    +        // if the status to merge is validating/invalid allow it to take 
precedence. whether the
             // processor run status is disabled/stopped/running is part of the 
flow configuration
    -        // and should not differ amongst nodes. however, whether a 
processor is invalid
    +        // and should not differ amongst nodes. however, whether a 
processor is validating/invalid
             // can be driven by environmental conditions. this check allows 
any of those to
             // take precedence over the configured run status.
    -        if (RunStatus.Invalid.name().equals(toMerge.getRunStatus())) {
    -            target.setRunStatus(RunStatus.Invalid.name());
    +        if 
(RunStatus.Validating.toString().equals(toMerge.getRunStatus())) {
    --- End diff --
    
    It's probably best to use .name() instead of .toString(), as toString() 
could potentially change at any time, whereas the name never will


---

Reply via email to