[ 
https://issues.apache.org/jira/browse/NIFI-5186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16482997#comment-16482997
 ] 

ASF GitHub Bot commented on NIFI-5186:
--------------------------------------

Github user mcgilman commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2722#discussion_r189701115
  
    --- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/manager/StatusMerger.java
 ---
    @@ -415,13 +415,15 @@ public static void merge(final 
ProcessorStatusSnapshotDTO target, final boolean
                 target.setType(toMerge.getType());
             }
     
    -        // if the status to merge is invalid allow it to take precedence. 
whether the
    +        // if the status to merge is validating/invalid allow it to take 
precedence. whether the
             // processor run status is disabled/stopped/running is part of the 
flow configuration
    -        // and should not differ amongst nodes. however, whether a 
processor is invalid
    +        // and should not differ amongst nodes. however, whether a 
processor is validating/invalid
             // can be driven by environmental conditions. this check allows 
any of those to
             // take precedence over the configured run status.
    -        if (RunStatus.Invalid.name().equals(toMerge.getRunStatus())) {
    -            target.setRunStatus(RunStatus.Invalid.name());
    +        if 
(RunStatus.Validating.toString().equals(toMerge.getRunStatus())) {
    --- End diff --
    
    I was just addressing an inconsistency because in the `DtoFactory` we 
populate run status with the value from `toString()`.


> Update UI to account for asynchronous validation
> ------------------------------------------------
>
>                 Key: NIFI-5186
>                 URL: https://issues.apache.org/jira/browse/NIFI-5186
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core UI
>            Reporter: Matt Gilman
>            Assignee: Matt Gilman
>            Priority: Blocker
>             Fix For: 1.7.0
>
>
> This Jira is a follow up to NIFI-950. The new asynchronous validation 
> introduces a new state VALIDATING. This VALIDATING state will be entered 
> following any modifications (create, update) to the component (Processor, 
> Controller Service, Reporting Task). All component validation is done in the 
> background on a recurring interval. When obtaining the current state, we will 
> return the last known state unless it is VALIDATING as a result of a 
> modification. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to