[
https://issues.apache.org/jira/browse/NIFI-5223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16489044#comment-16489044
]
ASF GitHub Bot commented on NIFI-5223:
--------------------------------------
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2736#discussion_r190596306
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-service-api/src/main/java/org/apache/nifi/serialization/RecordSetWriterFactory.java
---
@@ -76,5 +78,23 @@
* @return a RecordSetWriter that can write record sets to an
OutputStream
* @throws IOException if unable to read from the given InputStream
*/
- RecordSetWriter createWriter(ComponentLog logger, RecordSchema schema,
OutputStream out) throws SchemaNotFoundException, IOException;
--- End diff --
Instead of changing the interface method, wouldn't it be best to add a new
method? I know we already did this kind of change in the past but it's going to
break custom processors that would use the Record API. If we do that, could be
good to keep it in mind and mention it in the release/upgrade note.
> Allow the usage of expression language for properties of RecordSetWriters
> -------------------------------------------------------------------------
>
> Key: NIFI-5223
> URL: https://issues.apache.org/jira/browse/NIFI-5223
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Johannes Peter
> Assignee: Johannes Peter
> Priority: Major
>
> To allow the usage of expression language for properties of RecordSetWriters,
> the method createWriter of the interface RecordSetWriterFactory has to be
> enhanced by a parameter to provide a map containing variables of a FlowFile.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
