[
https://issues.apache.org/jira/browse/NIFI-5233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16490549#comment-16490549
]
ASF GitHub Bot commented on NIFI-5233:
--------------------------------------
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2738#discussion_r190857511
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-hbase-client-service-api/src/main/java/org/apache/nifi/hbase/HBaseClientService.java
---
@@ -42,24 +42,28 @@
" such as hbase-site.xml and core-site.xml for kerberos, " +
"including full paths to the files.")
.addValidator(new ConfigFilesValidator())
+
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
.build();
PropertyDescriptor ZOOKEEPER_QUORUM = new PropertyDescriptor.Builder()
.name("ZooKeeper Quorum")
.description("Comma-separated list of ZooKeeper hosts for
HBase. Required if Hadoop Configuration Files are not provided.")
.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
.build();
PropertyDescriptor ZOOKEEPER_CLIENT_PORT = new
PropertyDescriptor.Builder()
.name("ZooKeeper Client Port")
.description("The port on which ZooKeeper is accepting client
connections. Required if Hadoop Configuration Files are not provided.")
.addValidator(StandardValidators.PORT_VALIDATOR)
+
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
.build();
PropertyDescriptor ZOOKEEPER_ZNODE_PARENT = new
PropertyDescriptor.Builder()
.name("ZooKeeper ZNode Parent")
.description("The ZooKeeper ZNode Parent value for HBase
(example: /hbase). Required if Hadoop Configuration Files are not provided.")
.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
.build();
PropertyDescriptor HBASE_CLIENT_RETRIES = new
PropertyDescriptor.Builder()
--- End diff --
No specific reason. I was not sure it'd make sense to have different values
across multiple environments but since there is no overhead to allow it, let's
do it. As a general comment, I think we should start a discussion/JIRA
(probably tagged for NiFi 2.0) to default the scope to Variable Registry for
all the properties in the framework unless it's specifically disabled with
Scope.NONE.
> Enable expression language in Hadoop Configuration Files property of Hbase
> Client Service
> -----------------------------------------------------------------------------------------
>
> Key: NIFI-5233
> URL: https://issues.apache.org/jira/browse/NIFI-5233
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
> Affects Versions: 1.6.0
> Reporter: Gergely Devai
> Assignee: Pierre Villard
> Priority: Minor
> Labels: easyfix
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> In some Hadoop related processors (e.g. GetHDFS, DeleteHDFS) the "Hadoop
> Configuration Files" property supports expression language. This is
> convenient, as the lengthy paths to the config files can be stored in a
> property file loaded by Nifi at startup or in an environment variable, and
> the name of the property/environment variable can be referenced in the
> processors' configuration.
> The controller service HBase_1_1_2_ClientService also has the "Hadoop
> Configuration Files" property, but it does not support expression language.
> For the convenience reasons described above and for uniformity, it is
> desirable to allow expression language in that property as well.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
