[ https://issues.apache.org/jira/browse/NIFI-5229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16491484#comment-16491484 ]
ASF GitHub Bot commented on NIFI-5229: -------------------------------------- Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2735#discussion_r191038289 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-dbcp-service-bundle/nifi-dbcp-service/src/main/java/org/apache/nifi/dbcp/DBCPConnectionPoolLookup.java --- @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.dbcp; + +import org.apache.commons.lang3.StringUtils; +import org.apache.nifi.annotation.behavior.DynamicProperty; +import org.apache.nifi.annotation.documentation.CapabilityDescription; +import org.apache.nifi.annotation.documentation.Tags; +import org.apache.nifi.annotation.lifecycle.OnDisabled; +import org.apache.nifi.annotation.lifecycle.OnEnabled; +import org.apache.nifi.components.PropertyDescriptor; +import org.apache.nifi.components.ValidationContext; +import org.apache.nifi.components.ValidationResult; +import org.apache.nifi.controller.AbstractControllerService; +import org.apache.nifi.controller.ConfigurationContext; +import org.apache.nifi.expression.ExpressionLanguageScope; +import org.apache.nifi.processor.exception.ProcessException; +import org.apache.nifi.processor.util.StandardValidators; + +import java.sql.Connection; +import java.util.ArrayList; +import java.util.Collection; +import java.util.Collections; +import java.util.HashMap; +import java.util.List; +import java.util.Map; + +@Tags({ "dbcp", "jdbc", "database", "connection", "pooling", "store" }) +@CapabilityDescription("Provides a DBCPService that can be used to dynamically select another DBCPService. This service " + + "requires an attribute named 'database.name' to be passed in when asking for a connection, and will throw an exception " + + "if the attribute is missing. The value of 'database.name' will be used to select the DBCPService that has been " + + "registered with that name. This will allow multiple DBCPServices to be defined and registered, and then selected " + + "dynamically at runtime by tagging flow files with the appropriate 'database.name' attribute.") +@DynamicProperty(name = "The ", value = "JDBC property value", expressionLanguageScope = ExpressionLanguageScope.NONE, + description = "") +public class DBCPConnectionPoolLookup extends AbstractControllerService implements DBCPService { --- End diff -- This has the suffix "Lookup" but is really a Delegate in our terminology right? I'm thinking of (was it Joey's?) DB Lookup CS, or when/wherever we get a LookupService impl that can access RDBMS tables... > Implement a DBCPConnectionPool that dynamically selects a connection pool > ------------------------------------------------------------------------- > > Key: NIFI-5229 > URL: https://issues.apache.org/jira/browse/NIFI-5229 > Project: Apache NiFi > Issue Type: Improvement > Reporter: Bryan Bende > Priority: Major > Fix For: 1.7.0 > > > In NIFI-5121 we modified the DBCPConnectionPool interface to allow passing a > map of attributes (https://issues.apache.org/jira/browse/NIFI-5121). > We should implement a DBCPConnectionPool that lets you register multiple > other connection pools via dynamic properties, and then selects one based on > looking for an incoming attribute. > For example, lets say you create two regular connection pools A and B, then > in the new connection pool you would register: > a = pool1 > b = pool2 > and then the new connection pool will look in the attribute map for an > attribute like "database.id" and select the pool with the given id. -- This message was sent by Atlassian JIRA (v7.6.3#76005)