Github user MikeThomsen commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2745#discussion_r191388796
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/test/java/org/apache/nifi/lookup/TestCSVRecordLookupService.java
 ---
    @@ -66,4 +66,30 @@ public void testSimpleCsvFileLookupService() throws 
InitializationException, IOE
             assertEquals(EMPTY_RECORD, property3);
         }
     
    +    @Test
    +    public void testSimpleCsvFileLookupServiceWithCharset() throws 
InitializationException, IOException, LookupFailureException {
    +        final TestRunner runner = 
TestRunners.newTestRunner(TestProcessor.class);
    +        final CSVRecordLookupService service = new 
CSVRecordLookupService();
    +
    +        runner.addControllerService("csv-file-lookup-service", service);
    +        runner.setProperty(service, CSVRecordLookupService.CSV_FILE, 
"src/test/resources/test_Windows-31J.csv");
    +        runner.setProperty(service, CSVRecordLookupService.CSV_FORMAT, 
"RFC4180");
    +        runner.setProperty(service, CSVRecordLookupService.CHARSET, 
"Windows-31J");
    +        runner.setProperty(service, 
CSVRecordLookupService.LOOKUP_KEY_COLUMN, "key");
    +        runner.enableControllerService(service);
    +        runner.assertValid(service);
    +
    +        final CSVRecordLookupService lookupService =
    --- End diff --
    
    This isn't necessary.


---

Reply via email to