[
https://issues.apache.org/jira/browse/NIFI-5241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16498054#comment-16498054
]
ASF GitHub Bot commented on NIFI-5241:
--------------------------------------
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/2752
NIFI-5241: Updated EventSumValue to use synchronized methods instead …
…of many atomic values. This is more efficient and uses less heap. Also
noticed that the Logger instance in ProcessorNode was not used so removed it,
and in testing this also noticed that the default connection pool size for
OkHttpReplicationClient was only 5, which can cause a lot of unnecessary HTTP
connections to be created so adjusted the pool size
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi NIFI-5241
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2752.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2752
----
commit 14e5a228650a9995a7b030cc84fe7bf5e639cd93
Author: Mark Payne <markap14@...>
Date: 2018-06-01T14:21:17Z
NIFI-5241: Updated EventSumValue to use synchronized methods instead of
many atomic values. This is more efficient and uses less heap. Also noticed
that the Logger instance in ProcessorNode was not used so removed it, and in
testing this also noticed that the default connection pool size for
OkHttpReplicationClient was only 5, which can cause a lot of unnecessary HTTP
connections to be created so adjusted the pool size
----
> When calculating stats for components, use synchronized methods instead of
> atomic variables
> -------------------------------------------------------------------------------------------
>
> Key: NIFI-5241
> URL: https://issues.apache.org/jira/browse/NIFI-5241
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
> Reporter: Mark Payne
> Assignee: Mark Payne
> Priority: Major
> Fix For: 1.7.0
>
>
> Currently, the EventSumValue that is used to calculate stats for components,
> such as bytes in, bytes out, etc. using AtomicLong's and AtomicInteger's, etc
> to keep track of values. This made sense at first when there were only a few
> stats. Now, however, they hold about 17 different values and the atomic
> updates / atomic reads are more expensive than a synchronized method would
> be. This can cause sluggishness in the UI after the instance has been running
> for a while, especially if there are a lot of processors.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
