Github user joewitt commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2765#discussion_r193484189
--- Diff:
nifi-commons/nifi-json-utils/src/main/java/org/apache/nifi/processor/util/JsonValidator.java
---
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.processor.util;
+
+import com.fasterxml.jackson.databind.ObjectMapper;
+import org.apache.nifi.components.ValidationContext;
+import org.apache.nifi.components.ValidationResult;
+import org.apache.nifi.components.Validator;
+
+import java.util.List;
+import java.util.Map;
+
+public class JsonValidator implements Validator {
+ private ObjectMapper mapper = new ObjectMapper();
--- End diff --
having this here means it is subject to use by multiple threads and reused.
According to
https://github.com/FasterXML/jackson-databind/blob/master/src/main/java/com/fasterxml/jackson/databind/ObjectMapper.java#L78
We dont have guaranteed thread safety until the jackson 3.0 release.
---
