Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/360#discussion_r197824984
  
    --- Diff: extensions/librdkafka/PublishKafka.h ---
    @@ -115,14 +121,35 @@ class PublishKafka: public core::Processor {
           buffer.reserve(max_seg_size_);
           read_size_ = 0;
           status_ = 0;
    +      rd_kafka_resp_err_t err;
    +
    +      for (auto kv : flowFile_->getAttributes()) {
    +        if (regex_match(kv.first, attributeNameRegex_)) {
    +          if (!hdrs) {
    +            hdrs = rd_kafka_headers_new(8);
    --- End diff --
    
    Was eight randomly chosen? If not please add a comment for any maintainers 
to understand why you chose this number -- even if any number can be added or 
removed per  their API. 


---

Reply via email to