Github user kevdoran commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi/pull/130#discussion_r197971051
  
    --- Diff: minifi-docker/dockerhub/Dockerfile ---
    @@ -34,6 +34,8 @@ RUN mkdir -p $MINIFI_HOME
     
     RUN apk --no-cache add curl
     
    +ADD sh/ ${MINIFI_BASE_DIR}/scripts/
    --- End diff --
    
    Either format is valid, and in this case, equivalent. 
    
    From the [POSIX 
spec](http://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_06_02):
 
    
    > The simplest form for parameter expansion is:
    >
    >    ${parameter}
    >
    > The value, if any, of parameter shall be substituted.
    > 
    > The parameter name or symbol can be enclosed in braces, which are 
optional... If the parameter is not enclosed in braces, and is a name, the 
expansion shall use the longest valid name


---

Reply via email to