[
https://issues.apache.org/jira/browse/NIFI-5341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16525335#comment-16525335
]
ASF GitHub Bot commented on NIFI-5341:
--------------------------------------
GitHub user jtstorck opened a pull request:
https://github.com/apache/nifi/pull/2821
NIFI-5341 Enabled groovy tests in nifi-runtime
Fixed tests in NiFiGroovyTest in the nifi-runtime module
Updated NiFi.createBootstrapClassLoader to log a warning if lib/bootstrap
does not exist rather than throwing a FileNotFoundException, since it already
catches MalformedUrlException if there's an issue adding one of the bootstrap
JARs to the bootstrap classpath
Explicitly handling InvocationTargetException in NiFi.initializeProperties
to unwrap the cause and rewrap as an IllegalArgumentException to propogate the
real cause of the underlying exception thrown by NiFiPropertiesLoader
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [X] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jtstorck/nifi NIFI-5341
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2821.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2821
----
commit 174e213dc83cdbfa9e449c0b3b57f05673bc2167
Author: Jeff Storck <jtswork@...>
Date: 2018-06-27T02:33:19Z
NIFI-5341 Enabled groovy tests in nifi-runtime
Fixed tests in NiFiGroovyTest in the nifi-runtime module
Updated NiFi.createBootstrapClassLoader to log a warning if lib/bootstrap
does not exist rather than throwing a FileNotFoundException, since it already
catches MalformedUrlException if there's an issue adding one of the bootstrap
JARs to the bootstrap classpath
Explicitly handling InvocationTargetException in NiFi.initializeProperties
to unwrap the cause and rewrap as an IllegalArgumentException to propogate the
real cause of the underlying exception thrown by NiFiPropertiesLoader
----
> Groovy tests in nifi-runtime aren't running with the build
> ----------------------------------------------------------
>
> Key: NIFI-5341
> URL: https://issues.apache.org/jira/browse/NIFI-5341
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Affects Versions: 1.7.0
> Reporter: Jeff Storck
> Assignee: Jeff Storck
> Priority: Major
>
> At some point, NiFiGroovyTest in nifi-runtime stopped running with the build.
> During the work for NIFI-5176, it was discovered that
> build-helper-maven-plugin is not being invoked for nifi-runtime to explicitly
> add src/test/groovy to bind it to the test compile phase, and since there are
> no java tests, src/test/groovy is ignored, and the tests are not run.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
