Github user apiri commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/365#discussion_r199213790 --- Diff: libminifi/test/unit/UpdatePolicyTests.cpp --- @@ -0,0 +1,78 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +#include <uuid/uuid.h> +#include <vector> +#include <memory> +#include <utility> +#include <string> +#include "../TestBase.h" +#include "io/ClientSocket.h" +#include "core/Processor.h" +#include "../../controller/Controller.h" +#include "core/controller/ControllerService.h" +#include "c2/ControllerSocketProtocol.h" +#include "controllers/UpdatePolicyControllerService.h" + +TEST_CASE("TestEmptyPolicy", "[test1]") { + auto controller = std::make_shared<minifi::controllers::UpdatePolicyControllerService>("TestService"); + std::shared_ptr<minifi::Configure> configuration = std::make_shared<minifi::Configure>(); + controller->initialize(); + controller->onEnable(); + REQUIRE(false == controller->canUpdate("anyproperty")); +} + +TEST_CASE("TestEnableAll", "[test1]") { + auto controller = std::make_shared<minifi::controllers::UpdatePolicyControllerService>("TestService"); + std::shared_ptr<minifi::Configure> configuration = std::make_shared<minifi::Configure>(); + controller->initialize(); + controller->setProperty(minifi::controllers::UpdatePolicyControllerService::EnableAllProperties, "true"); + controller->onEnable(); + REQUIRE(true == controller->canUpdate("anyproperty")); +} + +TEST_CASE("TestEnableAllFalls", "[test1]") { --- End diff -- Falls -> Fails
---