Github user hemantha-kumara commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2828#discussion_r199443131
  
    --- Diff: nifi-docker/dockermaven/sh/start.sh ---
    @@ -26,6 +26,18 @@ prop_replace 'nifi.remote.input.host'           
"${NIFI_REMOTE_INPUT_HOST:-$HOST
     prop_replace 'nifi.remote.input.socket.port'    
"${NIFI_REMOTE_INPUT_SOCKET_PORT:-10000}"
     prop_replace 'nifi.remote.input.secure'         'false'
     
    +prop_replace 'nifi.cluster.is.node'                         
"${NIFI_CLUSTER_IS_NODE:-false}"
    +prop_replace 'nifi.cluster.node.address'                    
"${NIFI_CLUSTER_ADDRESS:-$HOSTNAME}"
    +prop_replace 'nifi.cluster.node.protocol.port'              
"${NIFI_CLUSTER_NODE_PROTOCOL_PORT:-}"
    +prop_replace 'nifi.cluster.node.protocol.threads'           
"${NIFI_CLUSTER_NODE_PROTOCOL_THREADS:-10}"
    +prop_replace 'nifi.cluster.node.protocol.max.threads'       
"${NIFI_CLUSTER_NODE_PROTOCOL_MAX_THREADS:-50}"
    +prop_replace 'nifi.zookeeper.connect.string'                
"${NIFI_ZK_CONNECT_STRING:-}"
    +prop_replace 'nifi.zookeeper.root.node'                     
"${NIFI_ZK_ROOT_NODE:-/nifi}"
    +prop_replace 'nifi.cluster.flow.election.max.wait.time'     
"${NIFI_ELECTION_MAX_WAIT:-5 mins}"
    +prop_replace 'nifi.cluster.flow.election.max.candidates'    
"${NIFI_ELECTION_MAX_CANDIDATES:-}"
    +
    +. "${scripts_dir}/update_cluster_state_management.sh"
    --- End diff --
    
    is this really required? updating zookeeper and root node in 
nifi.properties is enough ! isn't it?


---

Reply via email to