[ https://issues.apache.org/jira/browse/MINIFICPP-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16533714#comment-16533714 ]
ASF GitHub Bot commented on MINIFICPP-483: ------------------------------------------ GitHub user achristianson opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/369 MINIFICPP-483 Added compile-time bustache caveats Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file? - [x] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-483 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/369.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #369 ---- commit 678355315a79f2ad7c08079dce60a865298c01c3 Author: Andrew I. Christianson <andy@...> Date: 2018-07-05T14:17:35Z MINIFICPP-483 Added compile-time bustache caveats ---- > Add bustache build docs > ----------------------- > > Key: MINIFICPP-483 > URL: https://issues.apache.org/jira/browse/MINIFICPP-483 > Project: NiFi MiNiFi C++ > Issue Type: Documentation > Reporter: Andrew Christianson > Assignee: Andrew Christianson > Priority: Major > > Bustache adds some build-time caveats and this should be noted/clarified in > the build instructions. -- This message was sent by Atlassian JIRA (v7.6.3#76005)