Github user mattyb149 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2138#discussion_r204501742
  
    --- Diff: 
nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/AbstractHiveQLProcessor.java
 ---
    @@ -76,6 +86,38 @@
                 .addValidator(StandardValidators.CHARACTER_SET_VALIDATOR)
                 .build();
     
    +    public static final PropertyDescriptor QUERY_TIMEOUT = new 
PropertyDescriptor.Builder()
    +            .name("hive-query-timeout")
    +            .displayName("Query timeout")
    +            .description("Sets the number of seconds the driver will wait 
for a query to execute. "
    +                    + "A value of 0 means no timeout. NOTE: Non-zero 
values may not be supported by the driver.")
    +            .defaultValue("0")
    +            .required(true)
    +            .addValidator(StandardValidators.INTEGER_VALIDATOR)
    --- End diff --
    
    I missed this in the Hive 3 processors too, but shouldn't this be a 
NONNEGATIVE_INTEGER_VALIDATOR? Are there any situations in which a negative 
number has any semantics?


---

Reply via email to