Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/347#discussion_r205109263
--- Diff: extensions/http-curl/processors/InvokeHTTP.cpp ---
@@ -65,7 +65,13 @@ core::Property InvokeHTTP::FollowRedirects("Follow
Redirects", "Follow HTTP redi
core::Property InvokeHTTP::AttributesToSend("Attributes to Send", "Regular
expression that defines which attributes to send as HTTP"
" headers in the request. If
not defined, no attributes are sent as headers.",
"");
-core::Property InvokeHTTP::SSLContext("SSL Context Service", "The SSL
Context Service used to provide client certificate information for TLS/SSL
(https) connections.", "");
+core::Property InvokeHTTP::SSLContext("SSL Context Service",
+ "The SSL Context Service used to
provide client certificate "
+ "information for TLS/SSL (https)
connections.",
+ "",
+ false,
+ {},
+ {{"Remote URL", "^http:.*$"}});
--- End diff --
I see this comment chain can be a bit confusing -- there were offline
discussions that make it a bit worse. My request for a separate ticket was that
this and other PRs have made the usage of these classes very difficult to read
and use. I believe that it's bad enough that it warrants resolution in this
ticket or subsequent work. To make code worse and then fix it doesn't seem
correct; however, I'm okay with a subsequent ticket. I'm -1 with my opinion
merit especially since there was no discussion of this. I think Aldrin and
others can disagree and move forward with their +1s, through which I'll provide
an implicit agreement to move forward -- I'm also open to the possibility that
I'm completely wrong so let's actually have that discussion. My goal is not to
stop this but there was no discussion regarding how this and others have made
the code difficult to read and use.
---
