[
https://issues.apache.org/jira/browse/NIFI-5342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16561063#comment-16561063
]
ASF GitHub Bot commented on NIFI-5342:
--------------------------------------
GitHub user udaykale opened a pull request:
https://github.com/apache/nifi/pull/2923
NIFI-5342 CaptureChangeMySQL didn't escape database name
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/udaykale/nifi NIFI-5342
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2923.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2923
----
commit 6b31c6f4a3dd651ee0d14ab518e8ffc045c423bf
Author: uday <udaygkale@...>
Date: 2018-07-21T19:20:05Z
NIFI-5342 CaptureChangeMySQL didn't escape database name
----
> CaptureChangeMySQL didn't escape database name
> ----------------------------------------------
>
> Key: NIFI-5342
> URL: https://issues.apache.org/jira/browse/NIFI-5342
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Affects Versions: 1.6.0
> Reporter: Tanapol Nearunchorn
> Assignee: Uday Kale
> Priority: Major
>
> CaptureChangeMySQL didn't escape database name as you can see:
> [https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-cdc/nifi-cdc-mysql-bundle/nifi-cdc-mysql-processors/src/main/java/org/apache/nifi/cdc/mysql/processors/CaptureChangeMySQL.java#L1003]
>
> And also with the line 1004, which query from a table.
> It can cause problems when there is database or table name that contains a
> reserved keyword.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
