GitHub user ijokarumawak opened a pull request:
https://github.com/apache/nifi/pull/2981
NIFI-5282: GCPProcessor with HTTP Proxy with Authentication
## NOTE for reviewer
This PR contains two commits. The 1st one is submitted by @jugi92 via #2943
. I have reviewed the PR and updated few points. Please refer #2943 comments I
posted for where I have changed. With those changes, I'd give +1 to #2943, so
the 1st comment has 'this closes' comment.
The 2nd commit includes refactoring mentioned above, and also adds
ProxyConfiguration support on top of the 1st commit.
Please DO NOT squash these two commits when merging, in order to keep
@jugi92 contribution. Thanks!
## Some Docker commands to run Squid proxy server
```
# Start a Squid container
docker run -d -p 3128:3128 --name squid salrashid123/squidproxy tail -f
/dev/null
# Login to the container
docker exec -it squid bash
# Start proxy without auth
squid/sbin/squid -s -f squid.conf.forward
# or with basic auth
squid/sbin/squid -s -f squid.conf.basicauth
# Stop
squid/sbin/squid -k shutdown
```
---
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [x] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijokarumawak/nifi nifi-5282
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2981.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2981
----
commit cdae2b14b3ec596887585f921a9490ded737b345
Author: jugi92 <juliangimbel@...>
Date: 2018-08-10T09:48:58Z
NIFI-5282: GCPProcessor with HTTP Proxy with Auth
added http proxy support with authentication for GCP processors
added proxy support for Google Credential Service
This closes #2943.
Signed-off-by: Koji Kawamura <ijokaruma...@apache.org>
commit a5343434c556daa762dcab2a3af52c2cd12d7da2
Author: Koji Kawamura <ijokarumawak@...>
Date: 2018-08-31T09:47:59Z
NIFI-5282: Add ProxyConfigurationService to GCSProcessors
----
---
