Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/2990#discussion_r217135024 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessorResource.java --- @@ -668,6 +670,91 @@ public Response deleteProcessor( ); } + /** + * Updates the operational status for the specified processor with the specified values. + * + * @param httpServletRequest request + * @param id The id of the processor to update. + * @param requestRunStatus A processorEntity. + * @return A processorEntity. + * @throws InterruptedException if interrupted + */ + @PUT + @Consumes(MediaType.APPLICATION_JSON) + @Produces(MediaType.APPLICATION_JSON) + @Path("/{id}/run-status") + @ApiOperation( + value = "Updates run status of a processor", + response = ProcessorEntity.class, + authorizations = { + @Authorization(value = "Write - /processors/{uuid} or /operation/processors/{uuid}") + } + ) + @ApiResponses( + value = { + @ApiResponse(code = 400, message = "NiFi was unable to complete the request because it was invalid. The request should not be retried without modification."), + @ApiResponse(code = 401, message = "Client could not be authenticated."), + @ApiResponse(code = 403, message = "Client is not authorized to make this request."), + @ApiResponse(code = 404, message = "The specified resource could not be found."), + @ApiResponse(code = 409, message = "The request was valid but NiFi was not in the appropriate state to process it. Retrying the same request later may be successful.") + } + ) + public Response updateRunStatus( + @Context final HttpServletRequest httpServletRequest, + @ApiParam( + value = "The processor id.", + required = true + ) + @PathParam("id") final String id, + @ApiParam( + value = "The processor run status.", + required = true + ) final ProcessorRunStatusEntity requestRunStatus) { + + if (requestRunStatus == null) { + throw new IllegalArgumentException("Processor run status must be specified."); + } + + if (requestRunStatus.getRevision() == null) { + throw new IllegalArgumentException("Revision must be specified."); + } + + requestRunStatus.validateState(); + + if (isReplicateRequest()) { + return replicate(HttpMethod.PUT, requestRunStatus); + } else if (isDisconnectedFromCluster()) { + verifyDisconnectedNodeModification(requestRunStatus.isDisconnectedNodeAcknowledged()); + } + + // handle expects request (usually from the cluster manager) + final Revision requestRevision = getRevision(requestRunStatus.getRevision(), id); + // Create processor DTO to verify if it can be updated. + final ProcessorDTO requestProcessorDTO = new ProcessorDTO(); + requestProcessorDTO.setId(id); + requestProcessorDTO.setState(requestRunStatus.getState()); + + return withWriteLock( + serviceFacade, + requestRunStatus, + requestRevision, + lookup -> { + final NiFiUser user = NiFiUserUtils.getNiFiUser(); + + final Authorizable authorizable = lookup.getProcessor(id).getAuthorizable(); + OperationAuthorizable.authorize(authorizable, authorizer, RequestAction.WRITE, user); + }, + () -> serviceFacade.verifyUpdateProcessor(requestProcessorDTO), + (revision, runStatusEntity) -> { + // update the processor + final ProcessorEntity entity = serviceFacade.updateProcessor(revision, requestProcessorDTO); --- End diff -- We need to recreate this `requestProcessorDTO` using the `runStatusEntity` due to how we authorize/cache requests during our two phase commit.
---