[ 
https://issues.apache.org/jira/browse/NIFI-375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612583#comment-16612583
 ] 

ASF GitHub Bot commented on NIFI-375:
-------------------------------------

Github user mcgilman commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2990#discussion_r217121570
  
    --- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/manager/ControllerServiceEntityMerger.java
 ---
    @@ -137,7 +138,9 @@ public static void 
mergeControllerServiceReferences(final Set<ControllerServiceR
                     for (final ControllerServiceReferencingComponentEntity 
nodeReferencingComponentEntity : nodeReferencingComponents) {
                         final ControllerServiceReferencingComponentDTO 
nodeReferencingComponent = nodeReferencingComponentEntity.getComponent();
     
    -                    if 
(nodeReferencingComponentEntity.getPermissions().getCanRead()) {
    +                    final Boolean canRead = 
nodeReferencingComponentEntity.getPermissions().getCanRead();
    +                    final Boolean canOperate = 
nodeReferencingComponentEntity.getOperatePermissions().getCanWrite();
    +                    if (canRead || canOperate) {
    --- End diff --
    
    If `canRead` is false here, but `canOperate` is true, I believe we'd end 
update with a `NPE` since the referencing component should not be populated.


> New user role: Operator who can start and stop components
> ---------------------------------------------------------
>
>                 Key: NIFI-375
>                 URL: https://issues.apache.org/jira/browse/NIFI-375
>             Project: Apache NiFi
>          Issue Type: New Feature
>          Components: Core Framework
>            Reporter: Daniel Ueberfluss
>            Assignee: Koji Kawamura
>            Priority: Major
>
> Would like to have a user role that allows a user to stop/start processors 
> but perform no other changes to the dataflow.
> This would allow users to address simple problems without providing full 
> access to modifying a data flow. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to