[ https://issues.apache.org/jira/browse/NIFI-375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16613597#comment-16613597 ]
ASF GitHub Bot commented on NIFI-375: ------------------------------------- Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/2990#discussion_r217387530 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/RemoteProcessGroupResource.java --- @@ -434,6 +436,197 @@ public Response updateRemoteProcessGroupOutputPort( ); } + /** + * Updates the specified remote process group input port run status. + * + * @param httpServletRequest request + * @param id The id of the remote process group to update. + * @param portId The id of the input port to update. + * @param requestRemotePortRunStatusEntity The remoteProcessGroupPortRunStatusEntity + * @return A remoteProcessGroupPortEntity + */ + @PUT + @Consumes(MediaType.APPLICATION_JSON) + @Produces(MediaType.APPLICATION_JSON) + @Path("{id}/input-ports/{port-id}/run-status") + @ApiOperation( + value = "Updates run status of a remote port", + notes = NON_GUARANTEED_ENDPOINT, + response = RemoteProcessGroupPortEntity.class, + authorizations = { + @Authorization(value = "Write - /remote-process-groups/{uuid} or /operation/remote-process-groups/{uuid}") + } + ) + @ApiResponses( + value = { + @ApiResponse(code = 400, message = "NiFi was unable to complete the request because it was invalid. The request should not be retried without modification."), + @ApiResponse(code = 401, message = "Client could not be authenticated."), + @ApiResponse(code = 403, message = "Client is not authorized to make this request."), + @ApiResponse(code = 404, message = "The specified resource could not be found."), + @ApiResponse(code = 409, message = "The request was valid but NiFi was not in the appropriate state to process it. Retrying the same request later may be successful.") + } + ) + public Response updateRemoteProcessGroupInputPortRunStatus( + @Context final HttpServletRequest httpServletRequest, + @ApiParam( + value = "The remote process group id.", + required = true + ) + @PathParam("id") final String id, + @ApiParam( + value = "The remote process group port id.", + required = true + ) + @PathParam("port-id") final String portId, + @ApiParam( + value = "The remote process group port.", + required = true + ) final RemotePortRunStatusEntity requestRemotePortRunStatusEntity) { + + if (requestRemotePortRunStatusEntity == null) { + throw new IllegalArgumentException("Remote process group port run status must be specified."); + } + + if (requestRemotePortRunStatusEntity.getRevision() == null) { + throw new IllegalArgumentException("Revision must be specified."); + } + + requestRemotePortRunStatusEntity.validateState(); + + if (isReplicateRequest()) { + return replicate(HttpMethod.PUT, requestRemotePortRunStatusEntity); + } else if (isDisconnectedFromCluster()) { + verifyDisconnectedNodeModification(requestRemotePortRunStatusEntity.isDisconnectedNodeAcknowledged()); + } + + final Revision requestRevision = getRevision(requestRemotePortRunStatusEntity.getRevision(), id); + return withWriteLock( + serviceFacade, + requestRemotePortRunStatusEntity, + requestRevision, + lookup -> { + final Authorizable remoteProcessGroup = lookup.getRemoteProcessGroup(id); + OperationAuthorizable.isAuthorized(remoteProcessGroup, authorizer, RequestAction.WRITE, NiFiUserUtils.getNiFiUser()); --- End diff -- This should be calling `authorize` and not checking `isAuthorized`. > New user role: Operator who can start and stop components > --------------------------------------------------------- > > Key: NIFI-375 > URL: https://issues.apache.org/jira/browse/NIFI-375 > Project: Apache NiFi > Issue Type: New Feature > Components: Core Framework > Reporter: Daniel Ueberfluss > Assignee: Koji Kawamura > Priority: Major > > Would like to have a user role that allows a user to stop/start processors > but perform no other changes to the dataflow. > This would allow users to address simple problems without providing full > access to modifying a data flow. -- This message was sent by Atlassian JIRA (v7.6.3#76005)