Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2956#discussion_r217887181
--- Diff:
nifi-nar-bundles/nifi-neo4j-bundle/nifi-neo4j-processors/src/main/java/org/apache/nifi/processors/neo4j/Neo4JCypherExecutor.java
---
@@ -0,0 +1,203 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.neo4j;
+
+import java.io.ByteArrayInputStream;
+import java.nio.charset.Charset;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.stream.Collectors;
+
+import org.apache.nifi.annotation.behavior.EventDriven;
+import org.apache.nifi.annotation.behavior.InputRequirement;
+import org.apache.nifi.annotation.behavior.SupportsBatching;
+import org.apache.nifi.annotation.behavior.WritesAttribute;
+import org.apache.nifi.annotation.behavior.WritesAttributes;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.annotation.lifecycle.OnScheduled;
+import org.apache.nifi.annotation.lifecycle.OnStopped;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.components.PropertyValue;
+import org.apache.nifi.components.ValidationContext;
+import org.apache.nifi.components.ValidationResult;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.Relationship;
+import org.apache.nifi.processor.exception.ProcessException;
+import org.neo4j.driver.v1.Session;
+import org.neo4j.driver.v1.StatementResult;
+import org.neo4j.driver.v1.summary.ResultSummary;
+import org.neo4j.driver.v1.summary.SummaryCounters;
+
+import com.google.gson.Gson;
+
+@InputRequirement(InputRequirement.Requirement.INPUT_REQUIRED)
+@EventDriven
+@SupportsBatching
+@Tags({"neo4j", "graph", "network", "insert", "update", "delete", "put",
"get", "node", "relationship", "connection", "executor"})
+@CapabilityDescription("This processor executes a Neo4J Query
(https://www.neo4j.com/) defined in the 'Neo4j Query' property of the "
+ + "FlowFile and writes the result to the FlowFile body in JSON format.
The processor has been tested with Neo4j version 3.4.5")
+@WritesAttributes({
+ @WritesAttribute(attribute =
AbstractNeo4JCypherExecutor.ERROR_MESSAGE, description = "Neo4J error message"),
+ @WritesAttribute(attribute = AbstractNeo4JCypherExecutor.LABELS_ADDED,
description = "Number of labels added"),
+ @WritesAttribute(attribute =
AbstractNeo4JCypherExecutor.NODES_CREATED, description = "Number of nodes
created"),
+ @WritesAttribute(attribute =
AbstractNeo4JCypherExecutor.NODES_DELETED, description = "Number of nodes
deleted"),
+ @WritesAttribute(attribute =
AbstractNeo4JCypherExecutor.PROPERTIES_SET, description = "Number of properties
set"),
+ @WritesAttribute(attribute =
AbstractNeo4JCypherExecutor.RELATIONS_CREATED, description = "Number of
relationships created"),
+ @WritesAttribute(attribute =
AbstractNeo4JCypherExecutor.RELATIONS_DELETED, description = "Number of
relationships deleted"),
+ @WritesAttribute(attribute =
AbstractNeo4JCypherExecutor.ROWS_RETURNED, description = "Number of rows
returned"),
+ })
+public class Neo4JCypherExecutor extends AbstractNeo4JCypherExecutor {
+
+ private static final Set<Relationship> relationships;
+ private static final List<PropertyDescriptor> propertyDescriptors;
+
+ static {
+ final Set<Relationship> tempRelationships = new HashSet<>();
+ tempRelationships.add(REL_SUCCESS);
+ tempRelationships.add(REL_FAILURE);
+ relationships = Collections.unmodifiableSet(tempRelationships);
+
+ final List<PropertyDescriptor> tempDescriptors = new ArrayList<>();
+ tempDescriptors.add(CONNECTION_URL);
+ tempDescriptors.add(USERNAME);
+ tempDescriptors.add(PASSWORD);
+ tempDescriptors.add(QUERY);
+ tempDescriptors.add(LOAD_BALANCING_STRATEGY);
+ tempDescriptors.add(CONNECTION_TIMEOUT);
+ tempDescriptors.add(MAX_CONNECTION_POOL_SIZE);
+ tempDescriptors.add(MAX_CONNECTION_ACQUISITION_TIMEOUT);
+ tempDescriptors.add(IDLE_TIME_BEFORE_CONNECTION_TEST);
+ tempDescriptors.add(MAX_CONNECTION_LIFETIME);
+ tempDescriptors.add(ENCRYPTION);
+ tempDescriptors.add(TRUST_STRATEGY);
+ tempDescriptors.add(TRUST_CUSTOM_CA_SIGNED_CERTIFICATES_FILE);
+
+ propertyDescriptors =
Collections.unmodifiableList(tempDescriptors);
+ }
+
+ @Override
+ public Set<Relationship> getRelationships() {
+ return relationships;
+ }
+
+ @Override
+ public final List<PropertyDescriptor>
getSupportedPropertyDescriptors() {
+ return propertyDescriptors;
+ }
+
+ @OnScheduled
+ public void onScheduled(final ProcessContext context) {
+ super.onScheduled(context);
+ }
+
+ @Override
+ protected Collection<ValidationResult>
customValidate(ValidationContext validationContext) {
+ List<ValidationResult> results = new ArrayList<>();
+
+ PropertyValue trustStrategy =
validationContext.getProperty(AbstractNeo4JCypherExecutor.TRUST_STRATEGY);
+ if (trustStrategy.isSet() &&
trustStrategy.getValue().equals(AbstractNeo4JCypherExecutor.TRUST_CUSTOM_CA_SIGNED_CERTIFICATES.getValue()))
{
+ if ( !
validationContext.getProperty(AbstractNeo4JCypherExecutor.TRUST_CUSTOM_CA_SIGNED_CERTIFICATES_FILE).evaluateAttributeExpressions().isSet()
) {
+ results.add(new ValidationResult.Builder()
+ .subject(TRUST_STRATEGY.getDisplayName() + " with " +
TRUST_CUSTOM_CA_SIGNED_CERTIFICATES.getDisplayName())
+ .explanation(TRUST_STRATEGY.getDisplayName() + " with
" + TRUST_CUSTOM_CA_SIGNED_CERTIFICATES.getDisplayName() + " requires "
+ +
AbstractNeo4JCypherExecutor.TRUST_CUSTOM_CA_SIGNED_CERTIFICATES_FILE.getDisplayName()
+ " to be set").valid(false).build());
+ }
+ }
+ return results;
+
+ }
+
+ @Override
+ public void onTrigger(final ProcessContext context, final
ProcessSession session) throws ProcessException {
+ FlowFile flowFile = session.get();
+ if (flowFile == null) {
+ return;
+ }
+
+ String query =
context.getProperty(QUERY).evaluateAttributeExpressions(flowFile).getValue();
+
+ try {
+ long startTimeMillis = System.currentTimeMillis();
+
+ StatementResult statementResult = executeQuery(query);
+
+ List<Map<String, Object>> returnValue =
statementResult.list().stream().map(i ->
i.asMap()).collect(Collectors.toList());
+
+ getLogger().debug("Result of query {} is {}", new Object [] {
query, returnValue });
--- End diff --
Yes, I missed this one. Will correct it.
---
