[ 
https://issues.apache.org/jira/browse/NIFI-5514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16625830#comment-16625830
 ] 

ASF GitHub Bot commented on NIFI-5514:
--------------------------------------

Github user markap14 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2954#discussion_r219837666
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/MergeRecord.java
 ---
    @@ -304,13 +336,25 @@ public void onTrigger(final ProcessContext context, 
final ProcessSessionFactory
                 session.commit();
             }
     
    +        // If there is no more data queued up, complete any bin that meets 
our minimum threshold
    +        int completedBins = 0;
    +        final QueueSize queueSize = session.getQueueSize();
    --- End diff --
    
    @bdesert that's a great catch! I have pushed a new commit that updates the 
code like you suggested, to just check the size of the flowFiles list. I also 
created NIFI-5626 to address the inconsistency between MockProcessSession and 
StandardProcessSession.


> MergeRecord does not create a merged FlowFile until a maximum threshold is 
> reached
> ----------------------------------------------------------------------------------
>
>                 Key: NIFI-5514
>                 URL: https://issues.apache.org/jira/browse/NIFI-5514
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Extensions
>            Reporter: Mark Payne
>            Assignee: Mark Payne
>            Priority: Major
>             Fix For: 1.8.0
>
>
> MergeRecord allows the user to specify a minimum number of records. However, 
> if the minimum number of records is reached, the merged FlowFile is not 
> created unless the maximum number of records or max number of bytes is also 
> reached.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to