GitHub user thenatog opened a pull request:

    https://github.com/apache/nifi/pull/3024

    NIFI-5595 - Added the CORS filter to the templates/upload endpoint us…

    …ing a URL matcher.
    
    NIFI-5595 - Explicitly allow methods GET, HEAD. These are the Spring 
defaults when the allowedMethods is empty but now it is explicit. This will 
require other methods like POST etc to be from the same origin (for the 
template/upload URL).
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/thenatog/nifi NIFI-5595-rebased

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/3024.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3024
    
----
commit dca24d4f2d25f583dd3177a8c376dca32651d04d
Author: thenatog <thenatog@...>
Date:   2018-09-14T01:45:00Z

    NIFI-5595 - Added the CORS filter to the templates/upload endpoint using a 
URL matcher.
    
    NIFI-5595 - Explicitly allow methods GET, HEAD. These are the Spring 
defaults when the allowedMethods is empty but now it is explicit. This will 
require other methods like POST etc to be from the same origin (for the 
template/upload URL).

----


---

Reply via email to