[ 
https://issues.apache.org/jira/browse/MINIFICPP-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16654953#comment-16654953
 ] 

ASF GitHub Bot commented on MINIFICPP-647:
------------------------------------------

Github user arpadboda commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/420#discussion_r226237825
  
    --- Diff: libminifi/test/capi/CAPITests.cpp ---
    @@ -33,8 +32,14 @@
     #include <chrono>
     #include <thread>
     
    +static nifi_instance *create_instance_obj(const char *name = 
"random_instance") {
    +  nifi_port port;
    +  port.port_id = "12345";
    +  return create_instance("random_instance", &port);
    --- End diff --
    
    How can you set port after this? 


> Deprecate functions in API that pass char* in favor of those more strongly 
> typed
> --------------------------------------------------------------------------------
>
>                 Key: MINIFICPP-647
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-647
>             Project: NiFi MiNiFi C++
>          Issue Type: Improvement
>            Reporter: Mr TheSegfault
>            Priority: Blocker
>              Labels: CAPI
>             Fix For: 0.6.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to