[
https://issues.apache.org/jira/browse/MINIFICPP-649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655100#comment-16655100
]
ASF GitHub Bot commented on MINIFICPP-649:
------------------------------------------
GitHub user arpadboda opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/423
MINIFICPP-649 - Fix some compiler warnings
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/arpadboda/nifi-minifi-cpp MINIFICPP-649
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/423.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #423
----
commit f1de66109a001f75785c20779c9430133d4a025b
Author: Arpad Boda <aboda@...>
Date: 2018-10-18T11:50:27Z
MINIFICPP-649 - Fix some compiler warnings
----
> Fix some compiler warnings
> --------------------------
>
> Key: MINIFICPP-649
> URL: https://issues.apache.org/jira/browse/MINIFICPP-649
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: Arpad Boda
> Assignee: Arpad Boda
> Priority: Minor
> Fix For: 0.6.0
>
>
> Some warnings might be related to errors, these worth checking and fixing.
> For eg.:
> _/Users/aboda/work/shadow/minifi/nifi-minifi-cpp/LibExample/monitor_directory.c:43:3:
> warning: implicit declaration of function 'pthread_mutex_lock' is invalid in
> C99 [-Wimplicit-function-declaration]_
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
